Closed zmoon closed 1 year ago
@zmoon Thanks for reporting. I think I created this exercise and I honestly did not think about this. I will create a PR to change this and I would appreciate if you would review it.
@zmoon I think the exercise should now be correct, but please double check.
I believe the README.md is misleading. The instructions say that the matrix is given as a string with embedded newlines. This is the case in other tracks that implement this exercise (lua, typescript, python and PHP). Here, however, the tests use an array of strings representing the rows instead.
Closed by #175
There are some issues with the stub:
m
declaration doesn't have the dimension that it needs (:
)r
orc
) are wrong for bothrow
andcolumn
(they should be switched as it stands)A
declaration is not neededAlso, I feel that the dims should be reversed in the argument/tests. Although Fortran uses column-major storage order, I think most people still think of the first dimension as the "rows" dimension if you have a two-dimensional array (matrix). Wikipedia agrees: