exercism / fortran

Exercism exercises in Fortran.
https://exercism.org/tracks/fortran
MIT License
23 stars 30 forks source link

Issues with matrix exercise #170

Closed zmoon closed 1 year ago

zmoon commented 2 years ago

There are some issues with the stub:

Also, I feel that the dims should be reversed in the argument/tests. Although Fortran uses column-major storage order, I think most people still think of the first dimension as the "rows" dimension if you have a two-dimensional array (matrix). Wikipedia agrees:

in Fortran, arrays are stored in column-major order, while the array indexes are still written row-first (colexicographical access order)

pclausen commented 2 years ago

@zmoon Thanks for reporting. I think I created this exercise and I honestly did not think about this. I will create a PR to change this and I would appreciate if you would review it.

pclausen commented 2 years ago

@zmoon I think the exercise should now be correct, but please double check.

D3usXMachina commented 1 year ago

I believe the README.md is misleading. The instructions say that the matrix is given as a string with embedded newlines. This is the case in other tracks that implement this exercise (lua, typescript, python and PHP). Here, however, the tests use an array of strings representing the rows instead.

ErikSchierboom commented 1 year ago

Closed by #175