Closed avysk closed 1 year ago
Hello. Thanks for opening an issue on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.
That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use [this link](https://forum.exercism.org/new-topic?title=Errors%20in%20exercises%20CMakeLists.txt&body=%60%60%60%0D%0Aif(CMAKE_Fortran_COMPILER_ID%20MATCHES%20%22Intel%22)%20#%20Intel%20fortran%0D%0A%20%20if(WIN32)%0D%0A%20%20%20set%20(CCMAKE_Fortran_FLAG%20$%7BCCMAKE_Fortran_FLAGS%7D%20%22/warn:all%22)%0D%0A%20%20else()%0D%0A%20%20set%20(CMAKE_Fortran_FLAGS%20$%7BCCMAKE_Fortran_FLAGS%7D%20%22-warn%20all%22)%0D%0Aendif()%0D%0A%60%60%60%0D%0A1.%20%60CCMAKE%60%20should%20be%20%60CMAKE',%20in%20three%20places.%0D%0A2.%20%60FLAG%20%60%20should%20be%20%60FLAGS%20%60.%0D%0A3.%20But:%20tho%20code%20should%20really%20use%20%60FFLAGS%60%20instead%20of%20internal%20cmake%20%60CMAKE_Fortran_FLAGS%60.%20Setting%20the%20latter%20effectively%20blocks%20%60FFLAGS%60%20from%20being%20used%20at%20all.%0D%0A%0D%0ALower%20in%20the%20file%20there%20is%20a%20comment%20which%20reads%20%60GFrotran%60%20(yes,%20with%20a%20typo).%20Should%20be%20fixed%20as%20well.&category=fortran) to copy this into a new topic there.
Note: If this issue has been pre-approved, please link back to this issue on the forum thread and a maintainer or staff member will reopen it.
Issues -- not only PRs -- are autoclosed as well. "Go away, we are not going to fix anything."
CCMAKE
should beCMAKE
, in three places.FLAG
should beFLAGS
.FFLAGS
instead of internal cmakeCMAKE_Fortran_FLAGS
. Setting the latter effectively blocksFFLAGS
from being used at all.Lower in the file there is a comment which reads
GFrotran
(yes, with a typo). Should be fixed as well.