search

exercism / fsharp

Exercism exercises in F#.
https://exercism.org/tracks/fsharp
MIT License
107 stars 99 forks source link

Booking up for beauty example solution invalid #1232

Closed vaeng closed 4 weeks ago

vaeng commented 7 months ago

It seems like the implementation for the AM PM string representation has changed. The current proof solution from the repository does not work with the current test.

The current F# implementation does not use a space any longer between the time and the AM/PM.

https://github.com/exercism/fsharp/blob/930ca1cf056961485f7d03cafe0ebff52984a091/exercises/concept/booking-up-for-beauty/BookingUpForBeautyTests.fs#L161

KyleDickersonComposer commented 5 months ago

You can pass a date format into the ToString method of DateTime.

Screenshot 2024-04-11 at 10 13 16 PM
ErikSchierboom commented 5 months ago

There is something weird going on, as the tests have .Replace('\u202F', ' ') appended to them, but they still don't work. Whereas adding .Replace('\u202F', ' ') to the implementation works. I'll have a dig.

ErikSchierboom commented 5 months ago

I've just upgraded to the latest version of the exercise and now the tests do pass. Could you check that works for you @vaeng?

vaeng commented 5 months ago

Sweet. Looks like you've solved the exercise!

@ErikSchierboom Seems to work as intended! 🥳