search

exercism / func

Exercism exercises in FunC.
https://exercism.org/tracks/func
MIT License
1 stars 3 forks source link

New Exercises #10

Closed alirezatabatabaeian closed 7 months ago

alirezatabatabaeian commented 7 months ago

Hello dear @ErikSchierboom I've added three new exercises(Bank account + Error handling + Forth). Also, I've modified two exercises(Hello world + Change). I hope you can merge it.

Thanks Alireza

ErikSchierboom commented 7 months ago

I've added three new exercises(Bank account + Error handling + Forth). Also, I've modified two exercises(Hello world + Change).

I'll review shortly. As a general remark: please try to have pull requests do one thing only. In this case, that would mean this PR could been five different PRs:

  1. Add the back-account exercise
  2. Add the error-handling exercise
  3. Add the forth exercise
  4. Update the hello-world exercise
  5. Update the change exercise

The biggest benefits of this are:

  1. It makes it easier to review (and thus you'll likely get a review sooner)
  2. PRs can be merged sooner. Now, if there is a problem with any of the five changes, none of them can be merged,
ErikSchierboom commented 7 months ago

I hope you can also review the new tasks

I did, and they look good! Hence my approval (so feel free to merge).

alirezatabatabaeian commented 7 months ago

I guess I don't have any merge access!

ErikSchierboom commented 7 months ago

I guess I don't have any merge access!

You should have a Github invite to join the func team! Once joined, you'll have merge permissions.