search

exercism / github-actions

A collection of custom GitHub actions used throughout Exercism
7 stars 11 forks source link

Simplify secrets #65

Open SaschaMann opened 2 years ago

SaschaMann commented 2 years ago

https://github.blog/changelog/2022-05-03-github-actions-simplify-using-secrets-with-reusable-workflows/

ahtashamjaved commented 2 years ago

nice info thanks

hsadia538 commented 2 years ago

@SaschaMann I would Like to work on this, can you assign me ?

hsadia538 commented 2 years ago

@SaschaMann Initially I did not have much understanding of GitHub workflows and everything but after reading on it now I get what the article says Just putting here for confirmation: In all the caller flows, I have to add secrets: inherit right?

SaschaMann commented 2 years ago

@ErikSchierboom might be able to help you out, I'm not really active in this project anymore

hsadia538 commented 2 years ago

@ErikSchierboom can you verify?

ErikSchierboom commented 2 years ago

That is correct. I think there's just one location where this can be applied: https://github.com/exercism/org-wide-files/blob/main/tooling-files/.github/workflows/deploy.yml

We'd need to rename some settings for it to work at https://github.com/exercism/snippet-extractor/blob/main/.github/workflows/deploy.yml

hsadia538 commented 2 years ago

just for clarificationL: why do we need to rename settings at https://github.com/exercism/snippet-extractor/blob/main/.github/workflows/deploy.yml

ErikSchierboom commented 2 years ago

Because they use different names:

AWS_ECR_ACCESS_KEY_ID: ${{secrets.AWS_LAMBDA_ACCESS_KEY_ID}}
artfuldev commented 1 year ago

Hi, is this still useful and yet to be picked up? I have some time I can contribute to this issue with.

ErikSchierboom commented 1 year ago

I'm not entirely sure we want this. I sort of like the explicitness of the current setup.