search

exercism / gleam-test-runner

GNU Affero General Public License v3.0
3 stars 10 forks source link

Branch protection #22

Open iHiD opened 1 year ago

iHiD commented 1 year ago

I'd like to add branch protection here (it's standard across all exercism repos). The only change would be that all commits would need to go via PRs (but you could still self-merge) and that that we could add CI requirements.

Any objections? And any CI you'd like me to add as a requirement?

(cc @ErikSchierboom to action once @lpil has replied :))

lpil commented 1 year ago

Sounds good!!

ErikSchierboom commented 1 year ago

I've added branch protection to the main branch. You'll now be required to merge things via PRs (which you did anyway). The only other thing I added was that the CI workflow must be green in order for the PR to be mergeable. That okay with you?

lpil commented 1 year ago

Yup, perfect. Thank you

lpil commented 1 year ago

Could you disable the required review from @/exercism/maintainers-admin please? The Gleam team not being able to merge has been a big hit to productivity today.

iHiD commented 1 year ago

@lpil I'm happy to yes. But be aware that you'll be pretty much the only track without this extra guard. The reason we have it is so that if stuff goes wrong, it ensures that one of me/Erik are around to revert things and/or get logs out etc.

ErikSchierboom commented 1 year ago

Done

lpil commented 1 year ago

Thank you