Closed Rocche closed 3 months ago
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.
If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.
[no important files changed]
For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin
in a comment. Thank you!
Hey!
This pull request adds a (useless) not covered case in Gotta Snatch 'Em All` exercise, which is the "fake shiny" card (feel free to name the case the way you like).
Basically the instructions of the last part of the exercise states:
That means that cards starting with "Shiny" without a space should not be considered shiny cards. For example, the totally made up card Shinychu should not be considered as shiny. However in the current state of the exercise I could write a function that filters for strings starting with "Shiny" and the tests pass.
To correct this behavior, I added the Shinychu card to all the tests regarding shiny cards. For example:
This is probably a useless correction, but I think it better completes the exercise.