exercism / go-analyzer

GNU Affero General Public License v3.0
10 stars 12 forks source link

Update to Go 1.17 #26

Closed andrerfcsantos closed 2 years ago

andrerfcsantos commented 2 years ago

Part of https://github.com/exercism/go/issues/1881

Related PR's:

andrerfcsantos commented 2 years ago

Thanks for taking a look at this.

I'll go over this in more detail over the weekend and will keep you posted.

andrerfcsantos commented 2 years ago

@junedev Ran go mod vendor && go mod tidy and also updated gitignore to include the vendoring directory and binaries from go build.

I ran the tests with go test and they do seem to be failing. However, they are failing for the same reason in our current main. Seems like something we must look at, but I don't think it should be a blocker for this PR.

junedev commented 2 years ago

Thanks for the update and checking regarding the failing test. Feel free to merge this but please create an issue for the failing test cases if there isn't already one.

andrerfcsantos commented 2 years ago

Issue for the failing tests: https://github.com/exercism/go-analyzer/issues/29