Closed andrerfcsantos closed 2 years ago
Thanks for taking a look at this.
I'll go over this in more detail over the weekend and will keep you posted.
@junedev Ran go mod vendor && go mod tidy
and also updated gitignore to include the vendoring directory and binaries from go build
.
I ran the tests with go test
and they do seem to be failing. However, they are failing for the same reason in our current main
. Seems like something we must look at, but I don't think it should be a blocker for this PR.
Thanks for the update and checking regarding the failing test. Feel free to merge this but please create an issue for the failing test cases if there isn't already one.
Issue for the failing tests: https://github.com/exercism/go-analyzer/issues/29
Part of https://github.com/exercism/go/issues/1881
Related PR's: