search

exercism / go-test-runner

GNU Affero General Public License v3.0
15 stars 17 forks source link

new Dockerfile following builder conventions #3

Closed ghost closed 4 years ago

ghost commented 4 years ago

working but possibly more work required.

Still needed:

  1. Tests to validate that we've satisfied the request.
  2. Copying the entire /go directory in so that we can keep the compiled modules, is this a problem?
  3. Tidy up the repo
tehsphinx commented 4 years ago

About 2: This already uses Go modules, meaning all dependencies are frozen until we update them manually. About compilation time I wouldn't worry with Go.

Edit: Now I understand what you mean. But the compiled modules will never be used in the final docker container as we use the executable there.

tehsphinx commented 4 years ago

@SeventhNadir Thx a lot!