exercism / go-test-runner

GNU Affero General Public License v3.0
15 stars 17 forks source link

Text overflow issues #77

Closed AjaxAueleke closed 1 year ago

AjaxAueleke commented 2 years ago

image In some cards, the text goes out of the div which looks bad.

github-actions[bot] commented 2 years ago

Hi and welcome to Exercism! :wave:

Thanks for opening an issue :slightly_smiling_face:

iHiD commented 2 years ago

@exercism/go What's your appetite for adding some whitespace between the test name and the slash? 🙂

junedev commented 2 years ago

@iHiD Well, this is the output the built-in go test runner produces. In the code we write there are no underscores for example and even the slash is not added by us or some library. We can mess with that output of course but I am not sure only adding a space between test name and slash would be enough to fix this. The part with the underscores is still quite long and might not fit. Even if we shorten the text in the concept exercises, a lot of the descriptions coming from problem spec (canonical data) are also quite long.

So to really fix this we would need to add a space after the slash and replace all the underscores with spaces. But then the output people see on the website would look different from what they see locally. Are we ok with that?

Another thing to take into account: To me it looks like in the screenshot the area for the test output is particularly narrow and it can be adjusted via the slider. @AjaxAueleke Could you provide a screenshot of the full page and tell us what device/display size this is roughly? On my 13' laptop it fits if I have the "slider" roughly in the middle: image

This is not to say we shouldn't do anything to make it look better on other devices as well, I am just trying to understand where the problem occurs.

iHiD commented 2 years ago

Thanks for the explanation.

So to really fix this we would need to add a space after the slash and replace all the underscores with spaces.

This is what I did in the Ruby one, so I'm fine with it. But I don't know how easy/hard that would be in the Go setup.

junedev commented 2 years ago

Should be easy to do, just wanted to confirm its ok. Can you move the issue to the go test runner repo then?