exercism / go-test-runner

GNU Affero General Public License v3.0
15 stars 17 forks source link

eliminate the redundant empty line in the extracted individual test case #83

Closed dreig closed 1 year ago

dreig commented 1 year ago

Addresses #79

The redundant empty line can be traced to "ast.go", where the Elts attribute of the AST-node representing the slice of all test cases is replaced with the Elts attribute of an AST-node representing an individual test case. It can be observed in the following diff of the (partial) AST:

redundant-line-ast

I opted for replacing all of the contents of the slice-node (not just Elts, but also Lbrace)

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3321542438


Totals Coverage Status
Change from base Build 3321320140: 0.0%
Covered Lines: 397
Relevant Lines: 510

💛 - Coveralls
junedev commented 1 year ago

@ErikSchierboom Your comment says you approved but GitHub does not show any approval.

junedev commented 1 year ago

I reviewed this and it looks all fine and works as expected. Well done @dreig.

I would prefer if we could improve the tests as stated in the comment but if that turns out to be difficult, this can be merged as is.