Closed dreig closed 1 year ago
Totals | |
---|---|
Change from base Build 3321320140: | 0.0% |
Covered Lines: | 397 |
Relevant Lines: | 510 |
@ErikSchierboom Your comment says you approved but GitHub does not show any approval.
I reviewed this and it looks all fine and works as expected. Well done @dreig.
I would prefer if we could improve the tests as stated in the comment but if that turns out to be difficult, this can be merged as is.
Addresses #79
The redundant empty line can be traced to "ast.go", where the
Elts
attribute of the AST-node representing the slice of all test cases is replaced with theElts
attribute of an AST-node representing an individual test case. It can be observed in the following diff of the (partial) AST:I opted for replacing all of the contents of the slice-node (not just
Elts
, but alsoLbrace
)