eliminate the redundant empty line in the extracted individual test case

exercism / go-test-runner

GNU Affero General Public License v3.0

15 stars 17 forks source link

eliminate the redundant empty line in the extracted individual test case #83

Closed dreig closed 2 years ago

dreig commented 2 years ago

Addresses #79

The redundant empty line can be traced to "ast.go", where the Elts attribute of the AST-node representing the slice of all test cases is replaced with the Elts attribute of an AST-node representing an individual test case. It can be observed in the following diff of the (partial) AST:

I opted for replacing all of the contents of the slice-node (not just Elts, but also Lbrace)

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 3259326228

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

For more information on this, see Tracking coverage changes with pull request builds.
To avoid this issue with future PRs, see these Recommended CI Configurations.
For a quick fix, rebase this PR at GitHub. Your next report should be accurate.

Details

4 of 4 (100.0%) changed or added relevant lines in 1 file are covered.
No unchanged relevant lines lost coverage.
Overall coverage remained the same at 77.445%

Totals
Change from base Build 3184568547:	0.0%
Covered Lines:	388
Relevant Lines:	501

💛 - Coveralls

junedev commented 2 years ago

@ErikSchierboom Your comment says you approved but GitHub does not show any approval.

junedev commented 2 years ago

I reviewed this and it looks all fine and works as expected. Well done @dreig.

I would prefer if we could improve the tests as stated in the comment but if that turns out to be difficult, this can be merged as is.