exercism / go-test-runner

GNU Affero General Public License v3.0
15 stars 17 forks source link

Make go.mod of external-dependencies declare go 1.16 #88

Closed andrerfcsantos closed 1 year ago

andrerfcsantos commented 1 year ago

I was testing the external dependency support in one of the exercises and noticed something I wasn't aware: apparently, the Go version declared in the go.mod file affects the indirect dependencies that are downloaded. Since the exercises declare go 1.16 in their go.mod, for parity, the module controlling the dependencies should too.

Here's the problem I encountered:

The workaround for me was:

This PR changes external-dependencies/go.mod in a way that this workaround of changing the Go version of the exercise's go mod is not necessary.

coveralls commented 1 year ago

Pull Request Test Coverage Report for Build 3324510296


Totals Coverage Status
Change from base Build 3321664996: 0.0%
Covered Lines: 397
Relevant Lines: 510

💛 - Coveralls
ErikSchierboom commented 1 year ago

Ping me when a Go maintainer has reviewed this and I'll approve.

andrerfcsantos commented 1 year ago

@ErikSchierboom