exercism / go-test-runner

GNU Affero General Public License v3.0
15 stars 17 forks source link

Version 3 format does not work well when not all tests are executed #94

Closed junedev closed 1 year ago

junedev commented 1 year ago

grafik

Two problems as shown in the screenshot:

junedev commented 1 year ago

We had issues in the past where people said it would be better if all test cases (at least the parent tests) were listed all the time, even when they did not run, see https://github.com/exercism/go-test-runner/issues/47. It seems this is also what the version 3 UI expects, judging from counter for completed tasks at the top.

I am contemplating how to best address the issue in the screenshot. One idea would be to give the tests that did not run the status "error" and write in the message field that the test was not executed. Not sure how exactly that would look in the UI. @ErikSchierboom What do you think?

An ideal solution would be that the UI would support "test did not run" as a separate status with e.g. a grey dot and grey border.

ErikSchierboom commented 1 year ago

That would work just fine. This is a run of the Ruby test runner with none of the methods implemented, which are all returned as error statuses:

image

junedev commented 1 year ago

For reference, it looks very nice after the fix:

grafik