Update to Go 1.20

[andrerfcsantos]

Description

This is part of the upgrade of the track to Go 1.20:

• Updated CI to run Go 1.20
• Updated golangci-lint
• Updated main go.mod file
  • This caused the linter to fail due to ioutil being deprecated.
  • Deprecations were also addressed.
• Updated Docker image
• Updated external dependencies
  • Updated golang.org/x/text/language to 0.7.0 to address GO-2022-1059
  • Regenerated the go.sum for external dependencies using a go.mod set to 1.18

Related

PR that also should be merged for the track to be considered "upgraded":

• [ ] Update main repo: https://github.com/exercism/go/pull/2609

The following PRs should be merged eventually, but there's no rush since Go currently doesn't have the representer or the analyzer enabled:

• [ ] Update representer: https://github.com/exercism/go-representer/pull/34
• [ ] Update analyzer: https://github.com/exercism/go-analyzer/pull/40

[andrerfcsantos]

It seems the tests are now failing for 2 main reasons:

• TestRunTests_broken, which tests testrunner/testdata/practice/broken/ seems to fail with an error of returned exit code 1: exit status 1, but the tests expect returned exit code 2: exit status 2.
• For TestRunTests_passing the field message in the json is slightly off. For the subtests, in the message field, the command is returning [...]\n\n--- PASS: TestTrivialPass1/subtest_1.1[...], but the tests expect [...]\n\n --- PASS: TestTrivialPass1/subtest_1.1[...], i.e, the spaces before --- PASS are not present in the result of the command.

@junedev Do you know if this is due to the new format of go test -json and we can safely change what the tests expect or is it a problem in the code that we must address? Can't find any details on the go test -json change other than the release notes which doesn't explain in detail what changed.

[junedev]

@andrerfcsantos I updated the expected json files to what I think they should be. Currently, some tests fail though because e.g. the text that is returned as result of a panic is not included anymore. We will need to fix the actual code for this. (Potentially something related to stdout vs stderr.)

[coveralls]

Pull Request Test Coverage Report for Build 4308425118

• 11 of 17 (64.71%) changed or added relevant lines in 3 files are covered.
• 1 unchanged line in 1 file lost coverage.
• Overall coverage increased (+0.2%) to 63.176%

---

Changes Missing Coverage	Covered Lines	Changed/Added Lines	%
testrunner/execute.go	5	11	45.45%
<!--	Total:	11	17	64.71%	-->

Files with Coverage Reduction	New Missed Lines	%
testrunner/execute.go	1	52.35%
<!--	Total:	1		-->

Totals
Change from base Build 4286880947:	0.2%
Covered Lines:	362
Relevant Lines:	573

---

💛 - Coveralls

[junedev]

@andrerfcsantos I undrafted this so Erik can have a look. The main repo can be updated whenever we want after this is merged, they are not on the same Go version anyway since we use "latest" here and an older version for the exercises.

The representer and analayzer are not live so also no dependency regarding the update there.

Would be good if you can double check the changes to the expected outputs look ok to you.

[andrerfcsantos]

@junedev This is great, thanks!

The main repo can be updated whenever we want after this is merged, they are not on the same Go version anyway since we use "latest" here and an older version for the exercises. The representer and analayzer are not live so also no dependency regarding the update there.

Changed the descriptions accordingly.

Would be good if you can double check the changes to the expected outputs look ok to you.

It does. As far as I understand, after the changes you made it's just a couple of spaces removed before the ---, which I think is better.