search

exercism / go

Exercism exercises in Go.
https://exercism.org/tracks/go
MIT License
973 stars 649 forks source link

randomness: Update introduction on randomness #2630

Closed pawlik closed 1 year ago

pawlik commented 1 year ago

The seeding behavior changed in version 1.20, and some information was outdated.

I've split the section on Seeding in two: "Prior to 1.20" and "1.20 and later". But I'm open for suggestions if there's a better way to address it.

github-actions[bot] commented 1 year ago

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

junedev commented 1 year ago

A maintainer should apply some word smithing before merging this but I will re-open the PR as it is an important thing to address as we support Go 1.20 code on Exercism. Thanks for pointing this out!

andrerfcsantos commented 1 year ago

Since rand.Seed is being deprecated, we should probably address the recommendation to use it altogether and encourage the use of custom sources vi the exercise itself.

I've put this into my todo list and will take a look at it later.

pawlik commented 1 year ago

Thanks for re-opening :) Is there anything I could help with? I could try the "wordsmithing" part but I need more direct feedback. If you want to take it from here, it's also fine.

junedev commented 1 year ago

There was a lot more to fix here than just that one file. I decided to make another PR to adjust all the necessary files: https://github.com/exercism/go/pull/2688 I will close this one and merge the other one soon.