search

exercism / go

Exercism exercises in Go.
https://exercism.org/tracks/go
MIT License
948 stars 644 forks source link

prime-factors: use slices package to sort and compare test cases #2771

Closed zamai closed 3 months ago

zamai commented 3 months ago

I think this PR would be automatically closed, but wanted to leave it anyway, maybe'll figure out the forum later, but my tiny code reduction PR will be here already.

In this PR I moved slice sorting and comparison to use standard libs slices package, removed helpers that we're necessary before generics were introduced.

Value of this PR - removes code, enhances readability, showcases useful tools of stdlib :)

github-actions[bot] commented 3 months ago

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link%20&category=go ) to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.