Open fredefox opened 8 months ago
Hello. Thanks for opening a PR on Exercism 🙂
We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.
You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.
If you're interested in learning more about this auto-responder, please read this blog post.
Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.
This is an initial stab at #19. It looks for a name to task id mapping in the projects manifest file
metadata.json
. For instance forleap
the root object should be amended with an object like this:Or whatever the task id is supposed to be. This wasn't entirely clear to me.
I've added a module
Manifest.hs
that will look formetadata.json
. The mechanism used for locating the file simply assumes that thecwd
is where.exercism
is located. This might not be the most robust way to do it, but it is what the test runner seems to do. So I don't see any immediate benefit to improving this. Ifmetadata.json
is not located or fails to parse the task IDs are simply set tonull
in the generated report.Here is an example of how the output report changes with this patch for the
leap
task if you were to add an appropriate section inmetadata.json
:I've updated the tests. I had one issue with the tests where the GHC/Stack output seems to have changed wording subtly according to:
I had to add this change to get the tests to work with my local setup, though I appreciate we might need to not include it in the patch or do something else to accommodate the discrepancy.