search

exercism / haskell-test-runner

GNU Affero General Public License v3.0
1 stars 13 forks source link

Parse YAML before working on it #114

Closed MatthijsBlom closed 5 months ago

MatthijsBlom commented 5 months ago

Previously the list of test dependencies was extended through appending onto the containing file. This approach was fragile: exercism/haskell#1212, exercism/haskell#1241.

This patch avoids subsequent parsing problems by itself parsing the YAML before extending the list.

MatthijsBlom commented 5 months ago

I accidentally pushed this to main previously. That seems undesirable. I could not find a way to disallow this.

ErikSchierboom commented 5 months ago

I accidentally pushed this to main previously. That seems undesirable. I could not find a way to disallow this.

I've just added branch protection. We apparently forgot to set it.

ErikSchierboom commented 5 months ago

Thanks for this!

cdimitroulas commented 2 months ago

Thank you @MatthijsBlom :pray: