search

exercism / haskell-test-runner

GNU Affero General Public License v3.0
1 stars 13 forks source link

Haskell track maintainers for PRs to pre-compiled/package.yaml #53

Closed petertseng closed 2 years ago

petertseng commented 2 years ago

Looking through the history of PRs to pre-compiled/package.yaml in https://github.com/exercism/haskell-test-runner/commits/main/pre-compiled/package.yaml, it looks like for most of them (all but one), you've sought an opinion from a Haskell track maintainer. That makes sense if the track maintainers are making sure that the packages being added are reasonable. So if that's going to happen every time, maybe an update to https://github.com/exercism/haskell-test-runner/blob/main/.github/CODEOWNERS would be warranted, so that the track maintainers will automatically get added to PRs for that file?

It's just a suggestion; if you think there are cases where a track maintainer's input isn't necessary and therefore it should be left on a case-by-case basis instead of automatically, that's fine too.

ErikSchierboom commented 2 years ago

I completely agree. PR #54 opened.