search

exercism / haskell-test-runner

GNU Affero General Public License v3.0
1 stars 13 forks source link

Run scripts fail on errors #77

Closed hesselink closed 1 year ago

hesselink commented 1 year ago

Switches from sh to bash for the run-tests script since on Ubunto, sh is dash which doesn't have pipefail. Allows the commands stack test and diff to return a non-zero exit code, since this is expected during normal runs; any other failures will immediate fail the script.

To debug unexpected failures, set -x is also useful. We could consider setting this on CI.

github-actions[bot] commented 1 year ago

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.