Fix tests and Docker run

exercism / haxe-test-runner

MIT License

2 stars 5 forks source link

Fix tests and Docker run #11

Closed midyh closed 2 years ago

midyh commented 2 years ago

This PR renames all tests and removes the unnecessary identity folders. The Docker run scripts should also work now

ErikSchierboom commented 2 years ago

Three final comments:

It appears that the .sh files in the ./bin directory were all missing their executable bit. I've fixed this in https://github.com/exercism/haxe-test-runner/pull/11/commits/9807aa66b512dd212d2e23acb2832a04499d1470
The fact that the above missing executable bit did not show up, is because the main.yml workflow works on the wrong branch: master instead of main. This causes the workflow to not run.
The main.yml workflow can be simplified slightly: https://github.com/exercism/generic-test-runner/blob/main/.github/workflows/ci.yml#L19-L20

ErikSchierboom commented 2 years ago

@midyHamdoun The Haxe track is currently not active. If I look at its repo, it appears that it might be relatively little work to get it to an active state. Would you be interested in getting the Haxe track launched?

ErikSchierboom commented 2 years ago

@midyHamdoun But I'm happy to merge this and have the main workflow be addressed in a follow-up. Your preference?

midyh commented 2 years ago

@ErikSchierboom Hey! I'd be happy to get the Haxe track launched. What is the required work to do so? I'll address the main workflow in a next PR.

ErikSchierboom commented 2 years ago

Fantastic! Could you send me an email at erik@exercism.org? I'll get you up-to-speed with what needs to be happening. Exciting!