search

exercism / interactive-cli-walkthrough

13 stars 25 forks source link

Mistaken instructions for manually installing the macOS binary. #96

Open ynfle opened 3 years ago

ynfle commented 3 years ago

https://github.com/exercism/interactive-cli-walkthrough/blob/53b89e180b72bd6e0df88769362104a08a40090c/contents/mac/create_bin_folder.tw2#L41 instructs the user to run

mv ~/Downloads/BINARY_NAME ~/bin

however, the binary is in the extracted directory ie. ~/Downloads/exercism*/BINARY_NAME.

I would submit a PR for this but I'm not sure how to make it dependant on the architecture because the extracted folder name is different depending on which architecture the user is on.

Another option is to change the instruction to

mv ~/Downloads/exercism*/BINARY_NAME ~/bin

but may not be desired because they may have another folder in there.

kotp commented 3 years ago

The command to use might be nicer if there is a standard archive package that is used on the operating system. (Because we may not even have the guarantee that it is located in ~/Downloads because some folks download to /tmp where on reboot it is gone, saving the "housekeeping" of needing to clear out stale downloads.)

ynfle commented 3 years ago

My guess is that someone who knows to do that would be able to figure out to switch the commands that he is given. Also, the instructions specify Downloads. Plus, if we got with @NobbZ 's suggestion over here to use a wget/curl command instead of the GUI, then it would solve that issue.

kotp commented 3 years ago

Thanks, yeah, do you know if curl is by default installed? I don't mind either tool.

ynfle commented 3 years ago

I think it is but I'm not 100% sure. wget doesn't seem to be