search

exercism / java

Exercism exercises in Java.
https://exercism.org/tracks/java
MIT License
688 stars 672 forks source link

#48in24: Add analyzer feedback for Parallel Letter Frequency #2713

Open sanderploegsma opened 7 months ago

sanderploegsma commented 7 months ago

The Parallel Letter Frequency exercise on the Java track is being featured in the #48in24 challenge, which means that we expect an influx of students attempting to solve it during that week.

It would be nice if the exercise contains some more content by that time. One example of this is to add analyzer feedback for the exercise, to provide automated feedback on submitted solutions.

Adding analyzer feedback is done in three steps:

  1. Create (or update) the .meta/design.md file for the exercise explaining what type of feedback the analyzer should provide (example for the Leap exercise).
  2. Add the copy for the analyzer comments to exercism/website-copy.
  3. Implement the analyzer rules in exercism/java-analyzer.
yogan commented 6 months ago

Just as a reminder, the exercise text currently states that:

Single-threaded (non-concurrent) solutions can pass all tests but the last. Your solution will be tested for concurrency by submitting it as a Runnable to an ExecutorService. Your solution must leverage multiple Threads to pass the final test.

However, there is not (yet) such a test case.

Maybe for now remove that section and replace it with a note that participants should take care themselves that they are using some kind of parallelism in their solutions.

sanderploegsma commented 6 months ago

Thanks for the feedback, good to know! PR is welcome if you're willing to fix it yourself 😁

yogan commented 6 months ago

Can you give me a hint where I can the find the text for the exercise? I assumed it would be in this repository, but I have cloned it and searched for the mentioned paragraph without any matches.

sanderploegsma commented 6 months ago

Sure! Here it is: https://github.com/exercism/java/blob/main/exercises/practice/parallel-letter-frequency/.docs/instructions.append.md

yogan commented 6 months ago

Ah, it was in a hidden directory, so I didn't find it with a simple rg. Good to know.

Anyway, I've created a PR. Not sure if the linked resources are ideal (I'm not up-to-date with Java), but it was what I was using while doing the exercise.