search

exercism / java

Exercism exercises in Java.
https://exercism.org/tracks/java
MIT License
690 stars 671 forks source link

Adding analyzer feedback for `tim-from-marketing` concept exercise #2754

Closed manumafe98 closed 6 months ago

manumafe98 commented 6 months ago

pull request

closes #2687

This could be an example that triggers both comments

Reviewer Resources:

Track Policies

sanderploegsma commented 6 months ago

The example you linked is an interesting case: clearly the author has enough Java knowledge to understand the Nullable concept, or they wouldn't have chosen to use java.util.Optional. In these cases I'm not sure they will appreciate if the analyzer is being a wise-ass by pointing out that they should use null instead. On the other hand, the goal of this exercise is to practice using null.

I think I would prefer it if we leave an actionable comment that acknowledges that using java.util.Optional is a great way to deal with nullable arguments, but nudges the author to also try to solve the exercise without it. Once #2555 is completed, we could even point out that optionals are covered in a later concept.

What do you think?

manumafe98 commented 6 months ago

I think I would prefer it if we leave an actionable comment that acknowledges that using java.util.Optional is a great way to deal with nullable arguments, but nudges the author to also try to solve the exercise without it. Once #2555 is completed, we could even point out that optionals are covered in a later concept.

What do you think?

Sure, I like that!