Closed kahgoh closed 4 months ago
This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.
If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.
[no important files changed]
For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin
in a comment. Thank you!
Maybe it makes more sense to discuss this directly into an issue? how was the student solving the exercise to not meet with that particular test case?
@manumafe98 I've opened up a post in the forums to discuss: https://forum.exercism.org/t/missing-test-case-for-ability-with-lowest-number-occurring-twice-in-dnd-character/11097
@manumafe98 I've opened up a post in the forums to discuss: https://forum.exercism.org/t/missing-test-case-for-ability-with-lowest-number-occurring-twice-in-dnd-character/11097
Great! well we will see when it gets some answers!
pull request
During a mentoring session, I noticed a solution that passed all the existing tests, but would have failed to meet the following example from the instructions. I wonder if it be worth adding a test for it?
Note, I have put the PR here instead of the problem specifications because I noticed the Java track already has some tests around the
ability
method and the onlyability
test in the spec seems more vague. I think theability
tests we have might be Java specific?Reviewer Resources:
Track Policies