search

exercism / java

Exercism exercises in Java.
https://exercism.org/tracks/java
MIT License
697 stars 680 forks source link

Adding approach to Queen-Attack #2860

Open jagdish-15 opened 1 week ago

jagdish-15 commented 1 week ago

pull request

This pull request adds an approach to the Queen-Attack exercise.

I was unsure how to generate a uuid for the approach, so I've left it empty for now. I would greatly appreciate guidance on how to generate one.

Reviewer Resources:

Track Policies

tasxatzial commented 1 week ago

@jagdish-15 Have you looked at https://exercism.org/docs/building/configlet/uuid

jagdish-15 commented 5 days ago

@tasxatzial, thank you so much for letting me know! I couldn't find it anywhere—I guess I didn't search thoroughly enough in the documentation. But I've now configured the configlet and will be adding the UUID as soon as possible!

tasxatzial commented 5 days ago

Just by looking at the general structure of the files, it's probably a good idea to format them with one sentence per line. The maintainer will likely ask for it, see here

jagdish-15 commented 4 days ago

@tasxatzial, I've formatted the document as you requested. Thank you for the suggestions! Please let me know if there's anything else I should consider.

tasxatzial commented 4 days ago

@jagdish-15 Well, I can do a quick review of the general style (not the code), but I'd prefer to get permission from the maintainer first. Keep in mind that any changes I propose can be overridden by the maintainer, so I'll need to be extra careful with my suggestions to minimize your workload.

@kahgoh let me know if you need any help with this one.

jagdish-15 commented 4 days ago

Thanks, @tasxatzial! I appreciate your offer to review the style. I understand that any changes might be overridden by the maintainer, so I’ll leave it to you to proceed carefully.

@kahgoh, please let me know if you have any other feedback or if you'd like me to make any changes.

jagdish-15 commented 1 day ago

Hello @kahgoh,

I've updated this to align with all the consistency suggestions you provided for the previous PR here. Please take a look and let me know if there's anything else you'd like me to adjust.

kahgoh commented 21 hours ago

Thanks @jagdish-15, I've just gotten around to taking a look and posting the comments. Also thanks @tasxatzial for reviewing the style!

jagdish-15 commented 18 hours ago

Hello @kahgoh,

I've renamed the approach to the one you suggested, as it better aligns with the content and the overall approach (thank you for that!). Additionally, I've streamlined the content file by removing several unnecessary sections and making alterations to others. Could you take a look at the changes and let me know what you think?