search

exercism / java

Exercism exercises in Java.
https://exercism.org/tracks/java
MIT License
697 stars 680 forks source link

Sync yacht tests #2862

Closed kahgoh closed 13 hours ago

kahgoh commented 1 week ago

This task is to check the tests against those in the problem specification and update accordingly.

jagdish-15 commented 4 days ago

Hello @kahgoh!

Upon review, I found that the tests were already in sync. However, there was a minor discrepancy in the documentation that needed to be updated. I have raised a PR to sync the changes accordingly.

jagdish-15 commented 4 days ago

However, there are several other exercises that are not in sync, as shown in the screenshot below:

Screenshot 2024-11-16 010257

Would you like me to proceed with raising a PR to sync them all? Let me know if I have your go-ahead.

kahgoh commented 4 days ago

Thanks for looking into syncing Yacht! For some reason I had thought there was a test or two missing, but it appears to be all there when I looked again.

In regards to syncing the other tests, is it just the instructions and introduction Markdown files that need updating for them all? If so, feel free to sync them all under one PR. (Note, I am suggesting using just one PR to sync them all to avoid having to raise and go through many PRs).

jagdish-15 commented 3 days ago

Thanks for confirming about Yacht! Regarding the other exercises, there are indeed some tests that need to be synced as well, in addition to the instructions and introduction Markdown files. I'll take care of raising a PR to sync everything.

And don’t worry, I wouldn’t create separate PRs for each exercise — I'll handle it all in a single PR to keep the process efficient and streamlined. 😊

Thanks for the suggestion!

jagdish-15 commented 18 hours ago

Shouldn't we mark this issue as resolved since we have verified that the tests for the Yacht exercise are already in sync, and updates for the other exercises are currently in progress?

kahgoh commented 13 hours ago

Yeah, I think you're right because the original purpose was to just check the Yacht exercise, but that's done now. Closing this issue.