exercism / java

Exercism exercises in Java.

https://exercism.org/tracks/java

MIT License

697 stars 680 forks source link

Updating tests of Palindrome Product exercise to sync with the Problem-Specification repo #2872

Open jagdish-15 opened 1 day ago

jagdish-15 commented 1 day ago

pull request

Reviewer Resources:

Track Policies

github-actions[bot] commented 1 day ago

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

jagdish-15 commented 1 day ago

Hello @kahgoh,

This update adds a single test to sync with the problem-specifications repository. I believe marking it as [no important files changed] should be appropriate, but I’d appreciate your thoughts on this.

jagdish-15 commented 1 day ago

The java-test-runner is failing the test. Could this be because the reference solution doesn't pass the newly added tests? I believe that might be the case, but please let me know your thoughts.

kahgoh commented 21 hours ago

Yeah, looks like the reference implementation needs updating. It isn't super easy to see, but the CI logs contains the following:

Checking palindrome-products exercise...
palindrome-products: example solution did not pass the tests

jagdish-15 commented 20 hours ago

Sure, will do it as soon as possible.