search

exercism / javascript-analyzer

This is Exercism's automated analyzer for the JavaScript track.
GNU Affero General Public License v3.0
16 stars 16 forks source link

Incorrect Analysis: Semi-colon #128

Closed mathstrains21 closed 3 years ago

mathstrains21 commented 3 years ago

Describe the incorrectness I think the analyser should have pointed out my (deliberate) missing semi-colon.

Which exercise Annalyn's Infiltration, but could probably happen on any

Source file(s) annalyns-infiltration.js

// source file: <slug>.js
// Any line that can end with ';' not ending with ';'

Expected analysis I'd expect it to point out my missing semi-colon as it is a recommended thing to do.

Additional context Add any other context about the problem here.

junedev commented 3 years ago

Thanks for pointing this out but on Exercism, we have the rule that the analyzers and mentors should not comment on stylistic choices made by user. And while probably a lot of people would agree with you that having semicolons is a good thing, it is still a stylistic choice. As an example for the opposing view, this linter/formatter was very popular in the Node.js community a while ago and would remove semicolons https://standardjs.com/.