exercism / javascript

Exercism exercises in JavaScript.
https://exercism.org/tracks/javascript
MIT License
574 stars 615 forks source link

Simple Cipher unit tests do not check for keys with non alphanumeric characters #445

Closed xarxziux closed 6 years ago

xarxziux commented 6 years ago

I've just reviewed a submission for the Simple Cipher exercise where the student only checked for upper case letters and numbers in the key. This was enough to pass the unit tests, but does not conform to the requirements that state "Let's make your substitution cipher a little more fault tolerant by ... ensuring that the key contains only lowercase letters".

The unit tests for this exercise will need to be updated to test for this scenario.

tejasbubane commented 6 years ago

@xarxziux We maintain a canonical language-agnostic dataset of test cases for our exercises in this repo: https://github.com/exercism/problem-specifications. Can you create one issue there so it gets pushed to other languages as well?

xarxziux commented 6 years ago

I realised that after I created this issue and have already opened one:

https://github.com/exercism/problem-specifications/issues/1298

tejasbubane commented 6 years ago

Closed via #448