exercism / julia

Exercism exercises in Julia.
https://exercism.org/tracks/julia
MIT License
66 stars 69 forks source link

New practice exercise connect #718

Closed depial closed 3 months ago

depial commented 5 months ago

This is the practice exercise connect taken from problem-specifications with scaffolding created by configlet.

Possibly relevant points for reviewers to consider:

There are further possible edge cases related to the added one above, such as:

These are mostly to prevent the use of length checks , but the already added edge case above probably does enough to discourage that (e.g. isone(length(board)) && return first(board) no longer works). Otherwise, testing seems to be sufficient to check for correctness, but a couple more tests could be added to provide more symmetry. For example, more O wins could be added since, of the 11 original tests, there are only two O wins, and one of those is an edge case.

depial commented 3 months ago

If there is anyone @exercism/reviewers who would be interested in working with me to review some practice exercises to add to the track, please let me know.

depial commented 3 months ago

I've added my name to config.json, but I would rather prefer it be left off if possible.

Edit: reverted to an empty field for author's name, since adding mine is not necessary.

You can leave it off if you want. You just won’t get the additional rep points on Exercism for authoring the exercise (30 I believe). You’d only get rep for opening this PR.