Closed depial closed 3 months ago
If there is anyone @exercism/reviewers who would be interested in working with me to review some practice exercises to add to the track, please let me know.
I've added my name to config.json
, but I would rather prefer it be left off if possible.
Edit: reverted to an empty field for author's name, since adding mine is not necessary.
You can leave it off if you want. You just won’t get the additional rep points on Exercism for authoring the exercise (30 I believe). You’d only get rep for opening this PR.
This is the practice exercise
connect
taken fromproblem-specifications
with scaffolding created by configlet.Possibly relevant points for reviewers to consider:
example.jl
.connect
.[ "." ]
, meant to complement the 1x1 full boards,[ "X" ]
and[ "O" ]
. Nothing was added totests.toml
in regard to this.There are further possible edge cases related to the added one above, such as:
[ "" ]
0
wins:[ ". . . O . X . ." ]
X
wins:[ "X X X X" ]
These are mostly to prevent the use of length checks , but the already added edge case above probably does enough to discourage that (e.g.
isone(length(board)) && return first(board)
no longer works). Otherwise, testing seems to be sufficient to check for correctness, but a couple more tests could be added to provide more symmetry. For example, moreO
wins could be added since, of the 11 original tests, there are only twoO
wins, and one of those is an edge case.