search

exercism / julia

Exercism exercises in Julia.
https://exercism.org/tracks/julia
MIT License
68 stars 68 forks source link

update runtests.jl #788

Closed depial closed 2 months ago

depial commented 2 months ago

I finally got around to completing knapsack and I thought it could benefit from the use of a NamedTuple instead of the struct. I simply modified swapped out the struct and modified the tests to take a tuple. The example.jl remains untouched and still passes, so should all current solutions on the website (three users in total have completed as of writing this).

depial commented 2 months ago

@colinleach, maybe this might be a good time to try putting [no important files changed] in the commit body? There won't be a huge issue if we don't because there are only three solutions so far.

colinleach commented 2 months ago

this might be a good time to try putting [no important files changed] in the commit body

I'm happy either way, so it's your choice. I think you can merge when you're ready, now I've approved, but let me know if I have to do it. Many aspect of GitHub are still a bit mysterious to me.

depial commented 2 months ago

I didn't know I was going to be able to, but I've merged it. I had been merging yours after reviewing since I thought it was necessary for the reviewer to do so, but maybe I can just leave those for you to merge at your convenience from now on.

colinleach commented 2 months ago

It's all a bit confusing. Maybe a trial-and-error approach will get us through the early months of this.

depial commented 2 months ago

Let's hope so! :)