exercism / kotlin-test-runner

GNU Affero General Public License v3.0
4 stars 11 forks source link

update to Gradle 8.4 #54

Closed ErwinOlie closed 1 year ago

ErwinOlie commented 1 year ago

The changes in this PR consist of:

This is my first PR here. Feedback is welcome :)

github-actions[bot] commented 1 year ago

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

iHiD commented 1 year ago

(@ErikSchierboom See conversation at https://forum.exercism.org/t/kotlin-maintainer/7938/4)

ErwinOlie commented 1 year ago

Updated the description to tell what changed. I'll be adding a benchmark soon (but I don't expect any significant changes since maven is currently used for the test runs, if i'm not mistaken).

ErwinOlie commented 1 year ago

I time'd the docker run command in run-tests-in-docker.sh five times in a row on my own machine for both. Is that a good approach? I would like to give the performance problems a look as well later, can I use the same approach as a benchmark for that?

Before (Gradle 8.1.1 with some 6.0.1 wrappers)
real    0m54.529s
real    0m53.275s
real    0m53.502s
real    0m47.697s
real    0m54.221s
---
average 52.645s

After (Gradle 8.4.0)
real    0m57.295s
real    0m48.819s
real    0m57.015s
real    0m49.466s
real    0m49.706s
---
average 52.460s

I would argue that the little improvement can be seen as insignificant, especially since no change is expected.