exercism / kotlin-test-runner

GNU Affero General Public License v3.0
4 stars 11 forks source link

Add JUnit 5 support #55

Closed ErwinOlie closed 10 months ago

ErwinOlie commented 10 months ago
github-actions[bot] commented 10 months ago

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

ErwinOlie commented 10 months ago

@ErikSchierboom ready for review

ErikSchierboom commented 10 months ago

@ErwinOlie is the next step to update the exercises in the kotlin repo to use JUnit 5?

ErwinOlie commented 10 months ago

@ErikSchierboom I don't think it's necessary for the performance improvement ideas. We can backwards support jUnit4 with junit5-vintage-api. However I haven't tried this yet