search

exercism / lfe

Exercism exercises in Lisp Flavoured Erlang (LFE).
https://exercism.org/tracks/lfe
MIT License
25 stars 29 forks source link

Add Key Features and Icons. #174

Closed astyanax closed 11 months ago

astyanax commented 11 months ago

References:

github-actions[bot] commented 11 months ago

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

ErikSchierboom commented 11 months ago

Looking good. Juts needs a couple of tweaks to the length. See https://github.com/exercism/lfe/actions/runs/5734767189/job/15541463469#step:4:1

astyanax commented 11 months ago

Done @ErikSchierboom, thank you for your time :). Good opportunity to learn about Exercism's configlet. I'll try to install and use its lint/fmt actions in the future.

While I have your attention, 2 quick questions:

1) Existing config.json files have lines larger than 100, I assume this will be a problem with future PRs? JSON doesn't support multi-line strings, so one really has to compact the text in this limited space. It took some time to fix mine without losing important information, it was a nice editing exercise.

2) I assume non-maintainers can no longer provide (trivial) suggestions in tracks, correct? I noticed for example a typo in https://github.com/exercism/lua/blob/651978bebb6a9fc42e50297ac78996494c7e590b/config.json#L1142C26-L1142C36, but it sounds like it's more trouble than it's worth to fix it?

ErikSchierboom commented 11 months ago

Existing config.json files have lines larger than 100, I assume this will be a problem with future PRs?

Do you have specific examples?

I assume non-maintainers can no longer provide (trivial) suggestions in tracks, correct?

They can, but most tracks will see the PRs auto-closed. That said, if you have some minor fixes, feel free to ping me. I'd be happy to approve and merge a PR for the small typo you mentioned.

astyanax commented 11 months ago

Wonderful, cheers!

Do you have specific examples? So, I misunderstood the requirement: the value of content should be <= 100, not the full line, so all good!

All the examples I found (Perl, Prolog, Ruby, Python etc) had max content length between 95 and 100 characters (and some skipped . to gain that single character), so linting will be valid.