search

exercism / lua

Exercism exercises in Lua.
https://exercism.org/tracks/lua
MIT License
41 stars 57 forks source link

Custom set question #433

Closed elcarn23 closed 10 months ago

elcarn23 commented 10 months ago

When I was doing the custom set exercise in the spec file on line 65 the prompt says that it should indicate that it is not disjoint but the test itself is trying to assert true that a set is indeed disjoint with an empty set. Shouldn't that be checking for false indicating that it is not disjoint? I'm sorry if this is a silly question. I'm happy to update the spec file if we want to be checking that it is false.

github-actions[bot] commented 10 months ago

Hello. Thanks for opening an issue on Exercism 🙂

At Exercism we use our Community Forum, not GitHub issues, as the primary place for discussion. That allows maintainers and contributors from across Exercism's ecosystem to discuss your problems/ideas/suggestions without them having to subscribe to hundreds of repositories.

This issue will be automatically closed. Please use this link to copy your GitHub Issue into a new topic on the forum, where we look forward to chatting with you!

If you're interested in learning more about this auto-responder, please read this blog post.

ryanplusplus commented 10 months ago

Sorry for the delay looking at this. It looks like you're right and the test name is messed up. Will you make a PR to update the spec to fix this?

elcarn23 commented 10 months ago

Sure I've created a PR and it closed it immediately -- https://github.com/exercism/lua/pull/437. I had opened the topic on the forum as well -- https://forum.exercism.org/t/lua-track-custom-set-exercise/9086. They had updated the problem set code as well.

elcarn23 commented 10 months ago

Just saw that you re-opened it. I guess I should have waited a moment. Thanks for the chance to contribute even a little to the platform.