Open ynfle opened 2 years ago
is there any advantage to maintaining our own? It didn't seem like you are doing anything special in
bin/install_nim.sh
I wouldn't say there are huge advantages, but there are at least these benefits:
koch -d:leanCompiler
. It's more for making bootstrapping possible on memory-constrained devices, but it's probably also a marginal decrease in attack surface (there could be a security issue with docgen or JS codegen).exercism/nim-test-runner
(I wrote this part so that we don't include some larger directories like compiler/doc/tests).I'd suggest that we use exercism/nim-docker-base
for now - does that work for you? I'd be fine with reconsidering if it becomes a significant maintenance burden.
So I'm going to close this PR, but we can revisit it at a future date, perhaps when @ErikSchierboom is back in the virtual office
Let's discuss this once I'm back (next week).
This uses
nimlang/nim:1.6.0-alpine-regular
to copy over the alpine version of nim for the test-runner because it is already built and doesn't have to be rebuilt on every CI test.There are currently issues with this and I'll hopefully figure them out soon
Related to #116. The advantage of this route, is we don't have to maintain our nim base image (@ee7 is there any advantage to maintaining our own? It didn't seem like you are doing anything special in
bin/install_nim.sh
)