search

exercism / nim-test-runner

GNU Affero General Public License v3.0
2 stars 3 forks source link

Refactor: Prefer `dirExists` and `fileExists` #33

Closed ee7 closed 3 years ago

ee7 commented 3 years ago

This PR resolves some deprecation warnings.

Upstream:

CI log before this PR: 

/opt/test-runner/src/runner.nim(62, 10) Warning: use dirExists; existsDir is deprecated [Deprecated]
/opt/test-runner/src/runner.nim(25, 6) Hint: 'parseCmdLine' is declared but not used [XDeclaredButNotUsed]
/opt/test-runner/tests/trunner.nim(13, 15) template/generic instantiation of `suite` from here
/opt/test-runner/tests/trunner.nim(44, 16) template/generic instantiation of `test` from here
/opt/test-runner/tests/trunner.nim(45, 16) Warning: use fileExists; existsFile is deprecated [Deprecated]
/opt/test-runner/tests/trunner_repo_solutions.nim(8, 9) template/generic instantiation of `suite` from here
/opt/test-runner/tests/trunner_repo_solutions.nim(10, 12) Warning: use dirExists; existsDir is deprecated [Deprecated]
Hint:  [Link]
Hint: 81367 lines; 2.855s; 117.312MiB peakmem; Debug build; proj: /opt/test-runner/tests/trunner.nim; out: /opt/test-runner/tests/trunner [SuccessX]
Hint: /opt/test-runner/tests/trunner  [Exec]

CI log for this PR:

/opt/test-runner/src/runner.nim(25, 6) Hint: 'parseCmdLine' is declared but not used [XDeclaredButNotUsed]
Hint:  [Link]
Hint: 81367 lines; 3.277s; 117.309MiB peakmem; Debug build; proj: /opt/test-runner/tests/trunner.nim; out: /opt/test-runner/tests/trunner [SuccessX]
Hint: /opt/test-runner/tests/trunner  [Exec]
ynfle commented 3 years ago

Is there any reason not to merge this?

ee7 commented 3 years ago

Is there any reason not to merge this?

Not anymore. I just wanted to merge https://github.com/exercism/nim-test-runner/pull/34 first.