Closed ErikSchierboom closed 3 years ago
@ynfle It looks like you don't have review permissions for this repo. Would you be interested in having those permissions?
@ynfle It looks like you don't have review permissions for this repo. Would you be interested in having those permissions?
Which permissions? Didn't I used to have permissions?
Hmmm, there is something weird here. Both of you have approved, but they don't count as approving reviews. @iHiD could you check if the permissions are correct for @ee7 and @ynfle?
Hmmm, there is something weird here. Both of you have approved, but they don't count as approving reviews.
Isn't it just because the CODEOWNERS
file contains this?
https://github.com/exercism/nim-test-runner/blob/aba25f9aef205ddb08fe94cd62fb602af283b160/.github/CODEOWNERS#L1
Maybe a member of that team has to approve even when the PR was created by somebody in that team?
check if the permissions are correct for ee7 and ynfle
From the GitHub API I can confirm that the permissions in this repo are: | Permission | Users |
---|---|---|
push and pull | ee7, ynfle, ErikSchierboom | |
admin | iHiD, kytrinyx |
This PR adds a GitHub Actions workflow to automatically push a new version of this repo's Docker image to both Dockerhub and ECR. The former is used when running the tooling on your local machine using the development environment, the latter is currently used when running the tooling on our staging environment (https://exercism.lol/) but will eventually be used for our production website.
We've sent PRs to tooling repos before related to this functionality, but those PRs added two separate workflows for pushing to Dockerhub and ECR. With this PR, these workflows have been merged into a single workflow, which is much more efficient. If present, the old workflows will be removed in this PR.
See https://github.com/exercism/v3/issues/2969