Closed ynfle closed 3 years ago
Thank you for this! 💙
@ee7 is knee-deep in Conflgiet atm (which I imagine is going to take their time up till launch) so I suggest that if you're broadly happy with this, we just get it merged down and then any improvements can be made later, rather than get too caught up in review cycles at this stage. I've therefore tagged @ErikSchierboom who can maybe give it a quick sanity check for you for now! :)
@ee7 Had a requested a bunch of stuff that was requested and PRed on my branch (which I, unthoughtfully, deleted without waiting until this PR was merged) which can always be addressed later. @ee7, what do you think?
we just get it merged down and then any improvements can be made later, rather than get too caught up in review cycles at this stage
The main part of the review is done. I just need to do a couple of things to fix this PR. Don't merge this yet.
I think I'll be able to merge this within the next 24 hours.
we just get it merged down and then any improvements can be made later, rather than get too caught up in review cycles at this stage
The main part of the review is done. I just need to do a couple of things to fix this PR. Don't merge this yet.
I think I'll be able to merge this within the next 24 hours.
I rebased on main. What were you planning on fixing?
. What were you planning on fixing?
First I'll make CI green again - it's currently failing on this PR.
See https://github.com/exercism/nim-test-runner/pull/49.
Then I'll make it so the new test cases actually run. Currently they're silently skipped - scroll down here and notice that, although the check is green, no output capture tests actually ran.
Ping @iHiD - can you review this one too?
I'm setting this back to draft because I see:
Merging can be performed automatically with 1 approving review.
But I don't want automatic merging here - I want to merge this myself. And GitHub's automatic merging is new enough that I don't understand its subtleties.
Supersedes #26 (my mess up because I deleted my fork before this was merged) Closes #13
stdout
&stderr
and writing to jsonfail/multiple_tests_one_fail
output casesfail/multiple_tests_all_fail
output caseproc
instead offunc
anddebugEcho
pass/single_test_output
casepass/multiple_tests_output_truncated
pass/multiple_tests_output_unicode_truncated
execCmdEx
run
proc doc commentlet
to avar
pass/single_test_output_unicode
pass/single_test_output_stderr_only