Closed Norbiox closed 8 months ago
Hello. Thanks for opening a PR on Exercism 🙂
We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.
You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.
If you're interested in learning more about this auto-responder, please read this blog post.
Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.
Thanks. I took the liberty of pushing a first set of changes to your branch.
This is not yet ready to merge. I still want to at least:
append
append in placeadd
with append
, and len
with length
I should've read the canonical-data.json
first I see. Somehow I missed it in introduction video.
To example.nim
: I've used seq
everywhere, but it was refactored to the point that It's not my PR anymore.
Oh, I'm sorry to hear that.
Me too
I have added missing exercise "list-ops" according to my proposition in this thread on forum. Unfortunately I have failed to provide 2 tests and solutions for them - it's about handling nested lists in
concatenate
andreverse
. I've tried generics but found no working solutions. I also looked at implementations of this task in other statically typed languages, but they've been missing those cases too. As I'm pretty new to statically typed languages I need to deepen my understanding of that topic.