search

exercism / ocaml

Exercism exercises in OCaml.
https://exercism.org/tracks/ocaml
MIT License
94 stars 50 forks source link

Migrate finally from JBuilder to Dune #312

Closed sshine closed 5 years ago

sshine commented 5 years ago

In issue #265 / PR #271, @sbl did a heroic job at migrating from JBuilder to Dune, but it seems that a few references are still kept:

$ find . -iname "*jbuild*"
./exercises/palindrome-products/jbuild
./tools/test-generator/tmp/jbuild
./tools/test-generator/tmp/_build/default/.ppx/jbuild
./tools/test-generator/jbuild

$ ack -i jbuild
exercises/palindrome-products/Makefile
4:      jbuilder runtest
7:      jbuilder clean

exercises/palindrome-products/jbuild
1:(jbuild_version 1)

tools/test-generator/Makefile
8:      cp jbuild tmp; \
10:     jbuilder build test_gen.exe; \
17:     jbuilder clean

tools/test-generator/tmp/.merlin
81:FLG -ppx '/home/simon/exercism/ocaml/tools/test-generator/tmp/_build/default/.ppx/jbuild/ppx_deriving.eq+ppx_deriving.show+ppx_let/ppx.exe --as-ppx'

tools/test-generator/tmp/jbuild
1:(jbuild_version 1)

tools/test-generator/jbuild
1:(jbuild_version 1)

README.md
36:The Makefile is a slim wrapper around [dune](https://github.com/ocaml/dune). Each exercise has a jbuild file which describes how to build it.

docs/TESTS.md
2:We use [`jbuilder`](https://jbuilder.readthedocs.io/en/latest/) to build.
3:Each folder has a jbuild file specifying how to build and also a Makefile which delegates to jbuild.

In particular, our documentation says that we use jbuilder when we don't.

Since the "Second stage of the Jbuilder deprecation" was reached this January, 2019, let's finish the work of #271 eradicate references to JBuilder as good as we can.

sshine commented 5 years ago

Seen in a recent CI run:

----------------------------------------------------------------
running tests for: palindrome-products
The jbuilder binary is deprecated and will cease to be maintained in July 2019.
Please switch to dune instead.
The jbuilder binary is deprecated and will cease to be maintained in July 2019.
Please switch to dune instead.
File "jbuild", line 1, characters 0-0:
Warning: jbuild files are deprecated, please convert this file to a dune file instead.
Note: You can use "dune upgrade" to convert your project to dune.
        test alias runtest
............
Ran: 12 tests in: 0.00 seconds.
OK