exercism / ocaml

Exercism exercises in OCaml.
https://exercism.org/tracks/ocaml
MIT License
93 stars 50 forks source link

add devcontainer configuration #356

Closed marionebl closed 5 years ago

marionebl commented 5 years ago

This adds configuration for Visual Studio Code Remote - Containers. Using the mentioned extension with this config allows me to develop on the OCaml track in isolation, which helps with avoiding conflicts with other OCaml based projects and maintaining opam switches.

Usage:

Screenshot 2019-08-03 at 20 55 18
sshine commented 5 years ago

I'm not sure I fully dig having editor-specific preference files in the track repo.

This reminds me of e.g. Vim fold markers in source code: While this may benefit some, it is clutter to others.

So unless some of this relates to deployment (like with Travis and Docker-related configuration), would it be adequate to put those particular files in .gitignore so that your local setup can continue with them without popping up in git status and such?

marionebl commented 5 years ago

So unless some of this relates to deployment (like with Travis and Docker-related configuration), would it be adequate to put those particular files in .gitignore so that your local setup can continue with them without popping up in git status and such?

I'd be okay with this, just some points that might change the equation a bit

sshine commented 5 years ago

OK!

I think we should make development easier, and while I think many potential contributors to the track will already have most of the necessary Ocaml environment up and running, I'm sure we could boost interest in the track by providing an easy work environment. Perhaps, once this PR passes checks, we can move the documentation for installing this work environment into the repo's README.md.

Also, we should totally make a MirageOS exercise. :-D

marionebl commented 5 years ago

Perhaps, once this PR passes checks, we can move the documentation for installing this work environment into the repo's README.md.

Sounds very good. Might frame this as "skipping the line" / kickstart intro while keeping around the docs for full local setup

Also, we should totally make a MirageOS exercise. :-D

Excuse my ignorance but I don't understand the reference :(

sshine commented 5 years ago

It was a spur-of-the-moment idea that we should create an intro exercise for MirageOS: Making the track easier to work with for a particular workflow made me think of another Ocaml technology that I'd never gotten into. "How to get started with a certain Ocaml tech stack" is something we could have at the exercise level.

sshine commented 5 years ago

@kytrinyx: It says I'm not authorized to merge this pull request.

I thought that I was an Ocaml maintainer.

Are the Exercism organization groups on GitHub changing layout?

kytrinyx commented 5 years ago

I thought that I was an Ocaml maintainer.

I thought so too.

Are the Exercism organization groups on GitHub changing layout?

I'm sorry I don't understand the question. I've not made any changes aside from adding people to teams.

kytrinyx commented 5 years ago

@sshine You are an ocaml maintainer, and the ocaml team has write access to this repo. You are not allowed to merge?

marionebl commented 5 years ago

@sshine @kytrinyx Any chance to unblock us?

sshine commented 5 years ago

@kytrinyx, @ihid: No, apparently I'm not authorized to merge this pull request. Screenshot:

github-merging-blocked-to-authorized-users

iHiD commented 5 years ago

I think I've unblocked this. The branch protection settings weird strange on this. Can you merge now @sshine?

marionebl commented 5 years ago

Apparently I can merge approved PRs now, going ahead.

Thanks @iHiD

iHiD commented 5 years ago

Great. Thanks for confirming!