search

exercism / ocaml

Exercism exercises in OCaml.
https://exercism.org/tracks/ocaml
MIT License
93 stars 50 forks source link

Test all exercises with the offical docker test runner. #457

Closed georgyo closed 1 year ago

georgyo commented 1 year ago

When testing changes there was no ability to see how these changes would actually be tested by the ocaml-test-runner image.

A side effect of that is might be difficult to know if a change will actually be able to be tested once deployed. It was also difficult to make changes to the test runner and know if all existing problems will test as expected, resulting in broken exercises.

Hopefully this will help prevent future issues like this one: https://github.com/exercism/ocaml-test-runner/pull/37

This PR also uses some slightly more advanced Make features than the rest of the file. Specifically so you can you can pass -j to make. I was going to modify the test and clean but I don't know if that is desirable by the community.

github-actions[bot] commented 1 year ago

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.