search

exercism / ocaml

Exercism exercises in OCaml.
https://exercism.org/tracks/ocaml
MIT License
94 stars 50 forks source link

Rework test-generator to use Core and remove getopts #460

Closed georgyo closed 1 year ago

georgyo commented 1 year ago

This started because getopts has a rather unusal system dependency of bmake. bmake, at least on Archlinux, requires fiddling with the MAKESYSPATH environment variable to work.

While working there, there was several code base inconsistencies and subtle bugs. Such as creating directories with permission 640 meanining that directories it created could not be accessed by the user that crated them.

All the commands had incorrect help text on that arguments they took as well, making it even more difficult to use.

There are still a bunch of stubs, but hopefully a more consistent codebase will make it easier for people to contribute.

github-actions[bot] commented 1 year ago

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

georgyo commented 1 year ago

There were a few hiccups, such as missing core_unix and needing to rebase with other merged changes, but it is passing CI cleanly now.