search

exercism / ocaml

Exercism exercises in OCaml.
https://exercism.org/tracks/ocaml
MIT License
94 stars 50 forks source link

Fix broken test triangle #480

Closed Tran-AnTiem closed 1 year ago

Tran-AnTiem commented 1 year ago

I just fixed the is_scalene function which didn't return false when a triangle didn't have its three sides of different lengths.

github-actions[bot] commented 1 year ago

Hello. Thanks for opening a PR on Exercism. We are currently in a phase of our journey where we have paused community contributions to allow us to take a breather and redesign our community model. You can learn more in this blog post. As such, all issues and PRs in this repository are being automatically closed.

That doesn't mean we're not interested in your ideas, or that if you're stuck on something we don't want to help. The best place to discuss things is with our community on the Exercism Community Forum. You can use this link to copy this into a new topic there.

Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

georgyo commented 1 year ago

Sorry about the auto close, can you also delete the following file?

templates/triangle/.broken

Tran-AnTiem commented 1 year ago

It's done. @georgyo

georgyo commented 1 year ago

Very awesome stuff, thanks for contributing!

I've added the updated test-gen stuff. If you work on more, remember to do the following:

git submodule update --init
make generate_exercises