exercism / ocaml

Exercism exercises in OCaml.
https://exercism.org/tracks/ocaml
MIT License
93 stars 50 forks source link

Meetup: The stub is a complete solution #491

Closed Lattay closed 10 months ago

Lattay commented 10 months ago

Hi,

The stub provided in meetup is a complete solution that passes all test. Is this normal??

github-actions[bot] commented 10 months ago

Hello. Thanks for opening an issue on Exercism 🙂

At Exercism we use our Community Forum, not GitHub issues, as the primary place for discussion. That allows maintainers and contributors from across Exercism's ecosystem to discuss your problems/ideas/suggestions without them having to subscribe to hundreds of repositories.

This issue will be automatically closed. Please use this link to copy your GitHub Issue into a new topic on the forum, where we look forward to chatting with you!

If you're interested in learning more about this auto-responder, please read this blog post.

georgyo commented 10 months ago

Sorry for the auto-close, the removal of the pause on community contributions is still waiting review.

It seems like this was broken in this commit: https://github.com/exercism/ocaml/commit/02b80e77256e6433dc2461951cb72b057779d049

Feel free to send a PR either reverting that or fixing the the current stub. I'll be able to review and merge those contributions.

Lattay commented 10 months ago

Hi, No worries, I went on and signaled the problem on the forum. I guess the fix is fairly easy, just remove anything that is not strictly required to guide the student. I don't mind making such a PR if you are willing to merge it.

georgyo commented 10 months ago

Happy to merge it if you create the PR