ExercismSubmission will ignore files with no content

[gypsydave5]

Fixes #500 and #499

• necessitated a decoupling of the files from the valid files; the iterator now only uses the content dict for both filenames and contents

[ghost]

@iHiD @ErikSchierboom can you maybe approve it so we can test the idea of ignoring the stub files

[ghost]

@ErikSchierboom thanks, it seems we need another approval and someone with merge rights

[ErikSchierboom]

@RoelofWobben Nope. You had to approve and run the workflow runs

[ghost]

o, can I change it now so it's get merged ?

[ghost]

sorry, I do not see this choice here

[gypsydave5]

@RoelofWobben are you a maintainer (or similar) on this project? Can't see anything to indicate that you are... maybe that's the issue? Not sure what rights are necessary to merge this @ErikSchierboom (or who has them, as I'm also not in the org).

[ghost]

nope, as far as I know Pharo has no maintainer anymore. SamWatson was tthe last one and he left Pharo a while ago.

And I find for myself I do not have enough knowlegde and xp to be a good maintainer

[gypsydave5]

nope, as far as I know Pharo has no maintainer anymore.

Well.

And I find for myself I do not have enough knowlegde and xp to be a good maintainer

You're here, which is a pretty good start.

@ErikSchierboom might I suggest giving @Bajger, @RoelofWobben and myself merge rights on this track?

[ghost]

@gypsydave5 so you want yourself, me and @Bajger as maintainers. I can do that and you also

When you have this file change alumnus for me to false change the same for SamWatson to true and add yourself to the json file

Do not know if @bajger is happy that we add him as a maintainer

[gypsydave5]

But how will we change the file if we aren't maintainers 🤔

[ghost]

make the change so it will be a PR and ask @ErikSchierboom or @IHid to approve and merge it

[ErikSchierboom]

Let's hold off on this for a bit as we'll be deprecating the existing maintainers.json file soon-ish. Once we've done that (you'll see a PR to that extent), we can set you up as proper maintainers.

[ghost]

oke, then we have to wait with merging this one or can you merge it for one tme @ErikSchierboom

[gypsydave5]

I guess you could just hand-crank it for now and add us through the GitHub UI?

[Bajger]

Hi guys, I think I can participate on project (as far as I'm more and more familiar with track code), so you could add me to maintainer list.

[gypsydave5]

Well that's a relief @Bajger 😄

[ghost]

yep, nice to hear we can form a team. Love to work with you both @Bajger @gypsydave5

[ErikSchierboom]

Merged.