search

exercism / phix

Exercism exercises in Phix.
https://exercism.org/tracks/phix
MIT License
1 stars 3 forks source link

Launch tracking #1

Open ErikSchierboom opened 3 months ago

ErikSchierboom commented 3 months ago

Overall documentation for building an Exercism track lives at https://exercism.org/docs/building/tracks/new

This issue helps keep track of the tasks you're working on towards launching this track.

The next steps are:

Once you've finished a task, you can check them in this list.

Questions

Please ask if you have any questions or if anything is confusing!

petelomax commented 3 months ago

Where we at? (I'm about to pull this PC to bits and rebuild it, so might go dark for a couple of days, or more)

What needs to happen so that I can see how it will look?

ErikSchierboom commented 3 months ago

I don't have time right now to look into this. Maybe Tuesday or Wednesday.

ErikSchierboom commented 3 months ago

What needs to happen so that I can see how it will look?

I've just added the track to the database. This means that it will be available to all maintainers to use, which we can use to test out the track. I would suggest writing a forum post asking people for help with testing out the track.

petelomax commented 3 months ago

Excellent, thanks. I've made a forum post. Some snag with the test runner, though it seemed OK on the CI side. Should there be a separate phix-test-runner repo? Should I be doing anything with that bot PR?

kotp commented 2 months ago

@ErikSchierboom requested here for the test runner repository, but likely need the other two as well, at some point:

ErikSchierboom commented 2 months ago

Let me know when you need help

kotp commented 2 months ago

Let me know when you need help

Request for phix-test-runner in the forum message linked in the above message.

ErikSchierboom commented 2 months ago

I've created all three repos.

petelomax commented 2 months ago

Cannot commit or push anything - the button in GitHub Desktop is greyed out with no further clues. Do I need to be added as a maintainer?

ErikSchierboom commented 2 months ago

That is very weird. You're in the phix team and the phix team has write permissions on those repos.

petelomax commented 2 months ago

If I try and edit a file via (say) https://github.com/exercism/phix-test-runner/edit/main/bin/run.sh#L38C42 it says You can’t commit to main because it is a protected branch.

https://github.com/exercism/phix-test-runner/rules/1297839 looks wrong to me, or at least there is no similar rule on the main phix repo

ErikSchierboom commented 2 months ago

If I try and edit a file via (say) https://github.com/exercism/phix-test-runner/edit/main/bin/run.sh#L38C42 it says You can’t commit to main because it is a protected branch.

That is because we don't want people directly committing to main, you'll need to use PRs.

petelomax commented 2 months ago

And I've just proved why that's a good idea (in my defence I was more concerned with getting github to obey me rather than what I was actually meant to be doing), PR created, and fixed on three counts.