Upgrade to PHP 8.3 and PHPUnit 10

exercism / php-test-runner

GNU Affero General Public License v3.0

0 stars 6 forks source link

Upgrade to PHP 8.3 and PHPUnit 10 #105

Closed mk-mxp closed 2 months ago

mk-mxp commented 3 months ago

Replaces #100, which did not receive any updates for weeks.

Besides the expected changes concerning the actual version changes:

Adds the run.sh for test runs as volume like it was done for the test run script. This allows easier changes during development and does not harm any production things. There is a little risk of not having run.sh in the container and passing the CI anyways.
PHPUnit 10 no longer outputs data of data sets, so this had to be removed from the table tests. As the data providers are not a recommended way to write tests anyways (they lack feedback to the students in the online editor, have no good way to add the UUID etc.), I think this can be tolerated.

mk-mxp commented 3 months ago

Note to self: Wait a few days after https://github.com/exercism/php/pull/683 was merged before merging this.

tomasnorre commented 2 months ago

Thanks for taking care of this. I would have preferred a "ping" on the origin PR though. But not important. The one that do the action takes the decisions. :)

mk-mxp commented 2 months ago

I would have preferred a "ping" on the origin PR though. But not important. The one that do the action takes the decisions. :)

Sorry for obviously being rude. I didn't mean to be. To me, it seemed to be a decision between: "finish this with the solution at hand from debugging for #101 and push this forward", "hope tomasnorre hasn't lost motivation totally due to a lack of help and continue waiting for a solution" or "communicate the solution I found to you and hope you don't feel pushed along".

tomasnorre commented 2 months ago

Don't worry about it. I haven't lost motivation. But I have times when I get nothing done at all. So better someone does it, than it doesn't happen. No worries.